Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated imp package to importlib #215

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

robaerd
Copy link
Contributor

@robaerd robaerd commented Nov 1, 2023

This PR fixes #214 by migrating from imp to importlib.

@bmcfee
Copy link
Contributor

bmcfee commented Nov 22, 2023

Thanks for this, and sorry for the slow response. I'll merge this after we fix the CI to run on github actions so we can verify that it behaves correctly.

@hyve9
Copy link

hyve9 commented Mar 24, 2024

Just FYI, without this PR mirdata cannot be used with versions of python 3.11 or later

@bmcfee
Copy link
Contributor

bmcfee commented Mar 25, 2024

Just noting that I'll try to get this squared away this week. There are some blockers upstream that also needed to be updated (eg mir_eval) before this makes sense to do, but the work is mostly done at this point.

@bmcfee
Copy link
Contributor

bmcfee commented Dec 6, 2024

Sorry, this got away from me 🤦

The mir_eval reelase is still blocking CI updates, but this PR is okay for the time being. Bigger picture, we can actually do away with this importlib stuff entirely by modernizing the packaging info to use setup.cfg and pull version from attributes, rather than doing import hackery. But I can take that into a separate PR.

@bmcfee bmcfee merged commit b10b362 into marl:master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install fails on Python 3.12: imp Module Missing
3 participants