Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jams_to_mirex_pattern.py #194

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Conversation

irisyupingren
Copy link
Contributor

@irisyupingren irisyupingren commented Nov 15, 2018

A converter between the jams JKUPDD namespace and the submission format for the MIREX task

@bmcfee
Copy link
Contributor

bmcfee commented Nov 15, 2018

Apologies for the failing test build -- I'll get this patched up ASAP.

@bmcfee
Copy link
Contributor

bmcfee commented Nov 15, 2018

@irisyupingren if you pull the latest master, and do git rebase master from this branch, the tests should start working again.

However, since this PR doesn't touch the core library, the test failures here aren't particularly relevant -- I'll get a CR out ASAP. Thanks for doing this!

scripts/jams_to_mirex_pattern.py Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
for y in d:
# lopping through the events given an annotator
time = y["time"]
dur = y["duration"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dur is never used?

scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
scripts/jams_to_mirex_pattern.py Outdated Show resolved Hide resolved
@bmcfee
Copy link
Contributor

bmcfee commented Aug 9, 2019

Hey @irisyupingren , sorry to take literally forever to get around to this again. github wasn't showing your updated code in the review panel! At any rate, this looks good now. Is it okay to merge this for the next release? Thanks again for doing this, and for your patience!

@irisyupingren
Copy link
Contributor Author

No worries! It's been a while and it's good that everything's still up to date. Sure, looking forward to the next release :D

@bmcfee bmcfee merged commit ebdfd77 into marl:master Aug 9, 2019
@bmcfee bmcfee modified the milestones: 0.3.3, 0.3.4 Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants