-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create jams_to_mirex_pattern.py #194
Conversation
Apologies for the failing test build -- I'll get this patched up ASAP. |
@irisyupingren if you pull the latest master, and do However, since this PR doesn't touch the core library, the test failures here aren't particularly relevant -- I'll get a CR out ASAP. Thanks for doing this! |
scripts/jams_to_mirex_pattern.py
Outdated
for y in d: | ||
# lopping through the events given an annotator | ||
time = y["time"] | ||
dur = y["duration"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dur
is never used?
Hey @irisyupingren , sorry to take literally forever to get around to this again. github wasn't showing your updated code in the review panel! At any rate, this looks good now. Is it okay to merge this for the next release? Thanks again for doing this, and for your patience! |
No worries! It's been a while and it's good that everything's still up to date. Sure, looking forward to the next release :D |
A converter between the jams JKUPDD namespace and the submission format for the MIREX task