-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch requirements typo and advice request for requirements on apple M2 #19
Comments
Okay, I have a potential M2 setup but hard to tell if it's valid since I ran into other issues when running scripts. This is what I did, where pycond is aliased to /Users/ellemcfarlane/miniconda/envs/vcond/bin/python3 and python version is 3.9.16:
Note: some other dependency appears to ultimately change the numpy version to 1.24.3 I also:
Then, I run into runtime issues:
this looks like maybe somewhere
perhaps here main.py is being hardcoded via Would appreciate any tips for these issues 🙂 |
Hi, Regarding the PyTorch issue, I think it's best to install it from PyTorch's website. It depends on the info (my Linux system didn't run into any issues, but I can see how it might be different for macOS/Windows/different GPUs, etc). We might as well remove it from the requirements file and ask people to install it from: https://pytorch.org/get-started/locally/ Unfortunately, the other issues you are encountering are because of the gym==0.22 version. Both LBF and RWARE need 0.21 at the moment: With that version, lbforaging (or any other dependency) will load automatically when the environment name starts with it, e.g. "lbforaging:ENV-NAME" is identical to We are aware of both issues and looking into updating them. However, there is an issue deep within RWARE that doesn't make that easy. Can you give me more info on the |
Thanks for the quick response! Yeah, may make sense to ask people to install it manually. For now, I'll stick with my torch version unless I see it's breaking things. I tried installing gym 0.21 (and 0.20 as a sanity test), but run into this issue I've been trying to resolve:
Have you seen this? The Monitor bug happens in gym >= .23 (which was the default version installed with SB3 for me) due to this: https://github.com/openai/gym/releases/tag/0.23.0 that's why I downgraded to .22. |
By the way, any input on the second issues I described with search.py? |
I am not using pycond and can't reproduce the installation issue for gym (pip install gym==0.21) works fine in my system. Re search.py issue: I pushed a fix just now. It was trying to call "main.py" instead of "run.py" which was the old name. |
Great! Thanks for pushing a fix. I had to replace the python in the command to the path for my conda python bin since despite aliasing it to "python" the code run by click doesn't seem to use it so I get import issues. Also, had to change yaml.load to yaml.safe_load otherwise get this error:
After that, when running, I still see another error:
Re gym issue: yeah, sorry, pycond is just an alias to my cond python binary. It still failed for me with a clean environment, so I decided to install gym 21 with conda (which was also the fix for my numpy issue) and ran into a architecture issue. Then, I restarted from scratch, installed gym first, repeated the steps I mentioned above and now everything appears to work :)
|
For what it's worth, I ran into the gym 21 installation issue again, this time on linux & python 3.8. The issue is apparently caused by openai/gym#3176. The suggested solution for me didn't work for python 3.8 venv but did work for a python 3.9 conda env:
Maybe gym==0.21.0 should be added to the requirements? And maybe, in general, just providing a docker image would be best or is there some limitation for why this isn't practical? In either case, I can close this out as I got things to work on both macos and linux, thanks. |
I am running into installation issues on my M2 (macOS 13.2.1 (22D68)) using python 3.7.16 since 3.7 seemed to be required for the munch version specified (and is what is in setup.py). However, I seem to be running into what are maybe M2 issues:
torch issue which I suspect may be M2 related given that torch 1.8.1 supposedly supports python >= 3.6.2
and for cpprb and pandas this error:
I have spent a few hours going down rabbit holes to make it work (like keiohta/tf2rl#75), so I thought I would pause and ask if someone has gotten this working already on an M1/M2?
Also, the requirement pytorch==1.8.* I think should be changed to torch==1.8.*
The text was updated successfully, but these errors were encountered: