Add navigation sidebar to the docs #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
commented
Aug 3, 2018
| border: 0; | ||
| } | ||
| .github-corner:hover .octo-arm{animation:octocat-wave 560ms ease-in-out}@keyframes octocat-wave{0%,100%{transform:rotate(0)}20%,60%{transform:rotate(-25deg)}40%,80%{transform:rotate(10deg)}}@media (max-width:500px){.github-corner:hover .octo-arm{animation:none}.github-corner .octo-arm{animation:octocat-wave 560ms ease-in-out}} | ||
|
|
There was a problem hiding this comment.
I changed the old-school ribbon to a more modern corner that wiggles 
styfle
commented
Aug 3, 2018
| <li><a href="#contributing">Contributing</a></li> | ||
| <li><a href="#authors">Authors</a></li> | ||
| <li><a href="#license">License</a></li> | ||
| </ul> |
There was a problem hiding this comment.
We don't need navigation in each individual file since we have a global navigation menu now.
styfle
commented
Aug 4, 2018
| <li><a href="#renderer">The renderer</a></li> | ||
| <li><a href="#lexer">The lexer</a></li> | ||
| <li><a href="#parser">The parser</a></li> | ||
| </ul> |
There was a problem hiding this comment.
We don't need navigation in each individual file since we have a global navigation menu now.
styfle
commented
Aug 4, 2018
docs/index.html
Outdated
| <div id="container"> | ||
| <header> | ||
| <a href="#/README.md"> | ||
| <img src="img/logo-black.svg" height="64px" width="64px" /> | ||
| </a> | ||
| <h1>Marked.js Documentation</h1> | ||
| </header> | ||
| <div style="display: flex"> | ||
| <nav> |
There was a problem hiding this comment.
We begin the new <nav> here.
It's a sidebar on the left of the content.
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Mar 30, 2020
This was referenced Apr 6, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Add navigation sidebar to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/docsto be with other.mdfriendsContributor
Committer
In most cases, this should be a different person than the contributor.