Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow travis to pass when redos check fails #1256

Merged
merged 3 commits into from
May 8, 2018
Merged

Allow travis to pass when redos check fails #1256

merged 3 commits into from
May 8, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented May 7, 2018 •
edited by styfle
Loading

Markdown flavor: 7a9e35e

Description

  • Allows travis to pass even when npm run test:redos fails

image

closes #1254

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech requested review from styfle, joshbruce and davisjam May 7, 2018 20:58
styfle
styfle approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@styfle styfle mentioned this pull request May 7, 2018
Closed
4 tasks
@davisjam
Copy link
Contributor

davisjam commented May 8, 2018

Sounds good.

@davisjam davisjam removed their request for review May 8, 2018 13:58
davisjam
davisjam approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@styfle styfle merged commit dbd0dff into markedjs:master May 8, 2018
@UziTech UziTech deleted the test-travis branch February 19, 2019 20:19
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
Open
Open
This was referenced Mar 24, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 7, 2020
Open
Open
Open
Open
Open
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@styfle
Merge pull request markedjs#1256 from UziTech/test-travis
4c51d55 
Allow travis to pass when redos check fails
@snyk-bot snyk-bot mentioned this pull request Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisjam davisjam davisjam approved these changes

@styfle styfle styfle approved these changes

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UziTech @davisjam @styfle