Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow string arg from command line #1182

Merged
merged 4 commits into from
Apr 5, 2018
Merged

allow string arg from command line #1182

merged 4 commits into from
Apr 5, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 28, 2018

Marked version: 8489411

Description

Allow marked to use a string argument as input.

$ marked --string "*test*"
<p><em>test</em></p>

$ marked -s "*test*"
<p><em>test</em></p>

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this wasn't there before

@UziTech
Copy link
Member Author

UziTech commented Apr 2, 2018

I was too. You could use stdin but not an argument.

@styfle
Copy link
Member

styfle commented Apr 2, 2018

@UziTech Can you add docs for this new feature?

@UziTech
Copy link
Member Author

UziTech commented Apr 2, 2018

I added an example to the docs readme.

Is there another place we document the command line options?

@styfle
Copy link
Member

styfle commented Apr 2, 2018

@UziTech Not that I'm aware of but we probably should.

@styfle styfle requested a review from joshbruce April 2, 2018 23:44
@joshbruce
Copy link
Member

Don't want to break anything by fixing the merge conflicts. Think we should add this to the next release.

@UziTech
Copy link
Member Author

UziTech commented Apr 5, 2018

I rebased

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
allow string arg from command line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants