Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable bit from plain text files #75

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

Daniel15
Copy link
Contributor

Removes the executable bit (chmod a-x) from the license and readme, as it doesn't make sense for plain text files to be marked as executable.

Right now, this causes lint warnings when building a Debian package for a project that pulls in object-path as a dependency, as it thinks the file is an executable:

W: yarn: non-standard-executable-perm usr/share/yarn/node_modules/object-path/LICENSE 0744 != 0755

@coveralls
Copy link

coveralls commented Nov 13, 2016

Coverage Status

Coverage remained the same at 99.424% when pulling 60e8661 on Daniel15:noexec into f01ab7c on mariocasciaro:master.

@mariocasciaro
Copy link
Owner

Makes sense, thanks!

@mariocasciaro mariocasciaro merged commit c01b3f5 into mariocasciaro:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants