use echo_queries from mara_db.config.default_echo_queries #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since mara_db version 4.7.1 the echo_queries parameter is taken from mara_db.config.default_echo_queries when it is None. Since the config is by default set to True, we can safely remove all echo_queries=True calls in mara_pipeline. With this PR the mara_db.config.default_echo_queries config will apply to mara_pipeline as well.
|
@gathineou you merged already the PR in mara-db related to this, could you merge that here as well? |
martin-loetzsch
added a commit
that referenced
this pull request
Mar 8, 2021
- Fix CopyIncrementally with no data (#54) - Add ability to specify modification value type in CopyIncrementally (#53) 66e7dc1 Jan Katins <[email protected]> 4. Mar 2021 at 22:06 - Fix read stderr during command execution (#47) - Use echo_queries from mara_db.config.default_echo_queries (#58) - Include all versioned package files in wheel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mara_db version 4.7.1 the echo_queries parameter is by default taken from
mara_db.config.default_echo_querieswhen it isNone.The config is by default set to True, so, we can safely remove all
echo_queries=Truecalls in mara_pipeline.With this PR the mara_db.config.default_echo_queries config will apply to mara_pipeline as well.