Scripting: Fixed behavior of Dialog.SameWidgetRows #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new row was created automatically when adding a widget, it was failing to remember the type of that widget, since addNewRow was called after setting m_lastWidgetTypeName. Now the last widget type is set in addDialogWidget instead. Also, we no longer compare the type names but just compare the QMetaObject pointers directly. Also fixed a problem in ScriptDialog::deleteAllDialogs, which iterated the sDialogInstances container while it was also getting modified as each dialog was deleted. Closes mapeditor#3607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new row was created automatically when adding a widget, it was failing to remember the type of that widget, since
addNewRowwas called after settingm_lastWidgetTypeName.Now the last widget type is set in addDialogWidget instead. Also, we no longer compare the type names but just compare the
QMetaObjectpointers directly.Also fixed a problem in
ScriptDialog::deleteAllDialogs, which iterated thesDialogInstancescontainer while it was also getting modified as each dialog was deleted.Closes #3607