Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmxviewer can't view json-based maps #3866

Closed
eevee opened this issue Jan 8, 2024 · 1 comment · Fixed by #3870
Closed

tmxviewer can't view json-based maps #3866

eevee opened this issue Jan 8, 2024 · 1 comment · Fixed by #3870
Labels
bug Broken behavior.

Comments

@eevee
Copy link

eevee commented Jan 8, 2024

Just says

Error: Not a map file.

Looks like MapReader only reads XML. tmxrasterizer will happily render json maps, though, and even entire worlds.
@eevee eevee added the bug Broken behavior. label Jan 8, 2024
bjorn added a commit to bjorn/tiled-dev that referenced this issue Jan 9, 2024
@bjorn
tmxviewer: Added support for viewing JSON maps
1cce252 
The viewer can now read any default-enabled map format, which currently
only covers the JSON map format in addition to TMX.

Closes mapeditor#3866
@bjorn bjorn mentioned this issue Jan 9, 2024
Merged
bjorn added a commit to bjorn/tiled-dev that referenced this issue Jan 9, 2024
@bjorn
tmxviewer: Added support for viewing JSON maps
7f5e54b 
The viewer can now read any default-enabled map format, which currently
only covers the JSON map format in addition to TMX.

Closes mapeditor#3866
@bjorn
Copy link
Member

bjorn commented Jan 9, 2024

@eevee Indeed, I've changed it to use Tiled::readMap instead, and to call PluginManager::loadPlugins, such that now also JSON maps can be viewed.

The viewer is still very limited though, for example it can't even zoom in/out. But maybe it helps. :-)

bjorn added a commit that referenced this issue Jan 9, 2024
@bjorn
tmxviewer: Added support for viewing JSON maps
66509ac 
The viewer can now read any default-enabled map format, which currently
only covers the JSON map format in addition to TMX.

Closes #3866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tmxviewer: Added support for viewing JSON maps bjorn/tiled-dev
2 participants
@eevee @bjorn