This repository has been archived by the owner on Dec 3, 2018. It is now read-only.
Visual Studio 2014 support for node v0.10.x series #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -724,7 +724,7 @@ if options.use_ninja: | |||
| elif options.use_xcode: | |||
| gyp_args += ['-f', 'xcode'] | |||
| elif flavor == 'win': | |||
| gyp_args += ['-f', 'msvs', '-G', 'msvs_version=auto'] | |||
| gyp_args += ['-f', 'msvs', '-G', 'msvs_version=2013'] | |||
There was a problem hiding this comment.
Tricking gyp by asking for 2013 will not be needed once gyp upstream gets an understanding of 2014: https://code.google.com/p/gyp/issues/detail?id=446&q=2014
This was referenced Nov 13, 2014
enable 32bit again
Process.env setter: use wputenv instead of SetEnvironmentVariableW
Conflicts: common.gypi
Closed
|
@springmeyer I would recommend sending the patch to the gyp-developers mailing list. The issue tracker is a graveyard, in my experience. |
|
@bnoordhuis okay, thank you. My next step is to update it for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to get node v0.10.x working against Visual Studio 2014