Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Stretch tab in BayesFitting to meet MVP design pattern #38388

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

MohamedAlmaki
Copy link
Contributor

Description of work

This pull request replaces the old single-class Stretch tab with new model, presenter, and view classes to follow the MVP pattern. The goal of this work is to modernize the current codebase of the tab and adhere to best design practices.
Fixes #38005.

To test:

Follow the manual testing documentation and try to test multiple scenarios: https://developer.mantidproject.org/Testing/Inelastic/BayesFittingTests.html


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@MohamedAlmaki MohamedAlmaki added Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Nov 12, 2024
@MohamedAlmaki MohamedAlmaki added this to the Release 6.12 milestone Nov 12, 2024
@MohamedAlmaki MohamedAlmaki force-pushed the 38005_mvp_stretch branch 2 times, most recently from 6ed5fe6 to d35e523 Compare November 22, 2024 15:42
@MohamedAlmaki MohamedAlmaki force-pushed the 38005_mvp_stretch branch 3 times, most recently from 193fe5d to 95b8049 Compare November 25, 2024 18:42
@MohamedAlmaki MohamedAlmaki marked this pull request as ready for review November 26, 2024 08:39
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this much needed refactor! I've done a first pass through the code and have a couple of suggestions below

Please can you also add a test for the presenter and model?

@MohamedAlmaki MohamedAlmaki force-pushed the 38005_mvp_stretch branch 2 times, most recently from e026577 to 3ca2041 Compare December 5, 2024 11:20
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes, I have a few more minor suggestions then I'm happy to approve!

@MohamedAlmaki MohamedAlmaki force-pushed the 38005_mvp_stretch branch 4 times, most recently from 24df212 to c06c7da Compare December 6, 2024 15:21
@MohamedAlmaki MohamedAlmaki changed the title Refactor the Stretch tab in BayesFitting to meet MVP design pattren Refactor the Stretch tab in BayesFitting to meet MVP design pattern Dec 6, 2024
@robertapplin
Copy link
Contributor

This is working well, I have followed the manual testing instructions and it is working as expected. The only thing I noticed, is the options in the table are now non-editable, whereas it used to be possible to click in these table cells and change their value
image

@MohamedAlmaki
Copy link
Contributor Author

Fixed, it should work now

Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, this looks good to go 👍

@SilkeSchomann SilkeSchomann self-assigned this Dec 9, 2024
@SilkeSchomann SilkeSchomann merged commit cb03080 into main Dec 9, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 38005_mvp_stretch branch December 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

MVP for the Stretch tab of the Inelastic Bayes Fitting interface
3 participants