-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Stretch tab in BayesFitting to meet MVP design pattern #38388
Conversation
1460594
to
1be5945
Compare
6ed5fe6
to
d35e523
Compare
193fe5d
to
95b8049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this much needed refactor! I've done a first pass through the code and have a couple of suggestions below
Please can you also add a test for the presenter and model?
qt/scientific_interfaces/Inelastic/BayesFitting/StretchModel.cpp
Outdated
Show resolved
Hide resolved
qt/scientific_interfaces/Inelastic/BayesFitting/StretchView.cpp
Outdated
Show resolved
Hide resolved
qt/scientific_interfaces/Inelastic/BayesFitting/StretchPresenter.h
Outdated
Show resolved
Hide resolved
qt/scientific_interfaces/Inelastic/BayesFitting/StretchPresenter.h
Outdated
Show resolved
Hide resolved
e026577
to
3ca2041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes, I have a few more minor suggestions then I'm happy to approve!
qt/scientific_interfaces/Inelastic/BayesFitting/StretchModel.cpp
Outdated
Show resolved
Hide resolved
24df212
to
c06c7da
Compare
c06c7da
to
746f8a1
Compare
Fixed, it should work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this looks good to go 👍
Description of work
This pull request replaces the old single-class Stretch tab with new model, presenter, and view classes to follow the MVP pattern. The goal of this work is to modernize the current codebase of the tab and adhere to best design practices.
Fixes #38005.
To test:
Follow the manual testing documentation and try to test multiple scenarios: https://developer.mantidproject.org/Testing/Inelastic/BayesFittingTests.html
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.