Fix zeropadding for IMAT in Facilities.XML #18907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidFair
added
Framework
|
Tested locally and it now correctly picks up IMAT filenames |
|
@DavidFair Have their filenames always been padded to 8 digits or is it a recent change? |
|
I've just checked the runs in cycle 15_1 and they are all padded to 8 digits. |
martyngigg
added
the
Patch Candidate
|
Sorry - yes they have always had 8 digits as it is a (relatively) new instrument. |
martyngigg
added a commit
that referenced
this pull request
Feb 23, 2017
added zeropadding in facilities xml (cherry picked from commit e119e47) and modify patch release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick change that fixes being able to load IMAT workspaces through the data archive.
No related issue.