Add support for NeXus files in LoadVesuvio #18884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also bases the instrument prefix on the run number being loaded. Refs #18843
martyngigg
added
the
Indirect/Inelastic
martyngigg
added
the
Patch Candidate
louisemccann
approved these changes
Feb 17, 2017
|
LGTM |
|
Please don't merge this yet - I think the documentation test is a real failure |
|
@louisemccann Could you check this again after the builds finish? |
|
@louisemccann Could you double-check this again now? |
|
Able to load old and new files, |
|
Thanks |
|
The test failures on OSX are unrelated. They are the currently unstable MantidPlot tests. |
martyngigg
added
the
High Priority
martyngigg
added a commit
that referenced
this pull request
Feb 23, 2017
LoadVesuvio will not assume it uses RAW files It also bases the instrument prefix on the run number being loaded. Refs #18843 (cherry picked from commit 60a878c) Disable logging of delete workspace coperations Refs #18843 (cherry picked from commit 540f561) Remove unused variable Refs #18843 (cherry picked from commit a394e3b) Fix LoadVesuvio run finder when extension is provided. Refs #18843 (cherry picked from commit ce56023) Only pass strings to LoadVesuvio Refs #18843 (cherry picked from commit 339d13f) Revert config changes after each documentation test Refs #18843 (cherry picked from commit 6f4cee4) Fix loader in case path contains "-" character Refs #18843 (cherry picked from commit 41f8add) Fix full path handling properly Refs #18843 (cherry picked from commit 6c508da) Add patch release note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work.
Uses
LoadinLoadVesuvioso that it can use either.rawor.nxsfiles.To test:
This will need to be tested at ISIS with access to the data archive.
Run
25999uses the new long naming convention and is a standard 6-period file - this should now load withLoadVesuvio.Also check older files still load, i.e ones prefixed
EVSFixes #18843
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.