Transpose KLE JSON to be row-wise #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleCJ
force-pushed
the
wrangle_kle
branch
2 times, most recently
from
4a00b6e to
f8cbe88
Compare
UncleCJ
force-pushed
the
wrangle_kle
branch
from
f7c5985 to
8f9ec7b
Compare
Except for the font size of `Paste` and some others (not present in the rendered image) and removal of trailing slash in URL (a matter of taste) these are intended to be functionally neutral. Partly I suggest these as simplifications, but mainly because they align with the following commit transposing the data
These image references were broken
For information, you can use advanced Git features to locate things like
these:
git log --author manna -p -S data/logos
git grep master/manna-harbour-boa
This corresponds to qmk/qmk_firmware#7426
This brings the data one step closer to generating from miryoku-babel. It took quite some fiddling, and KLE will immediately re-align it again upon import or editing, but at least this is source data which is simpler to understand and edit raw. KLE (as one [quickly discover](https://github.com/ijprest/keyboard-layout-editor/wiki/Serialized-Data-Format)) render a stateful/relative source (in order to reduce redunant parameters such as "render the next key") into a stateless/absolute result, in particular complicating the order of rotations and font properties. WIP: Transpose other KLE diagrams, starting with Base Layer WIP: Transpose Button layer WIP: Features layer WIP: Functions layer WIP: Add missing AltGr This corresponds to qmk/qmk_firmware#7426
UncleCJ
force-pushed
the
wrangle_kle
branch
from
8f9ec7b to
8db92ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority, should one want to continue illustrations based on KLE. This brings the data one step closer to generating from miryoku-babel.
It took quite some fiddling, and KLE will immediately re-align it again upon import or editing, but at least this is source data which is simpler to understand and edit raw.
KLE (as one quickly discover) render a stateful/relative source (in order to reduce redundant parameters such as "render the next key") into a stateless/absolute result, in particular complicating the order of rotations and font properties.
This would make keys the same order as, and align regular row-staggered layouts with this default, simplifying changes I care about, such as #106.