-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display scheduled flows as such #301
Comments
Thanks for catching this. I think scheduler should be treated just like http:listener. The generated diagram should look similar to how a single flow with http:listener would look. If the scheduler can be registered as a source in known-components, that can make it work without any code change. Scheduler belongs to the default |
Yes, thought about it. Problem could be that then probably all flows are triggered by the identical scheduler, because the scheduler doesn't have a sensible path. We could use the name, frequency or the doc:id, but the name/freq is often not unique, and the there is no point in printing doc:id as the path. Therefore I thought about handling scheduler as something different than a "normal" source. |
Yes, Schedulers do not have any config or path. Doc id/name should not be used for anything except documenting. In general, the source graphical representations should stay consistent for all source elements. In general, schedulers with cron expression (with property placeholder) is a best/preferred practice. I think we could use the cron expression value as a path value. If any implementation doesn't use cron, then the diagram can at least help uncover that and move to cron for better representation in the diagram. What do you have in mind for "something different than a "normal" source"? |
Allow configuring core components in known components csv file and identifying corresponding components. Fixes #301 by rendering schedulers from mule core components.
Allow configuring core components in known components csv file and identifying corresponding components. Fixes #301 by rendering schedulers from mule core components.
PR #304 adds the support for mule core components. Here is a rendered diagram for scheduler flows. Scheduler element does not have any path-eligible attribute at the element level. Using <scheduler doc:name="Scheduler" doc:id="8a2088ba-a947-438c-97e5-b124f4386b18" >
<scheduling-strategy >
<cron expression="${cron.expresion}" />
</scheduling-strategy>
</scheduler> |
Scheduled flows are not displayed with a source, so they look like they are never called.
A scheduler can be either displayed as a source (though without path or config), or a flow could be marked (with an icon or a different color)
The text was updated successfully, but these errors were encountered: