Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSI sanity check #119

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Remove MSI sanity check #119

merged 1 commit into from
Nov 3, 2021

Conversation

manicminer
Copy link
Owner

@manicminer manicminer commented Nov 2, 2021

Remove MSI sanity check, since it's opinionated and works not in various envs such as CloudShell. The value added is comparitively small, since a similar error will occur slightly further along anyway when the first API call is attempted.

🧪 Tested on a linux VM and in Cloud Shell

Closes: #116
Related: hashicorp/terraform-provider-azuread#633

…us envs such as CloudShell. The value added is comparitively small, since a similar error will occur slightly further along anyway when the first API call is attempted
@manicminer manicminer added bug Something isn't working package/auth labels Nov 2, 2021
@manicminer manicminer added this to the v0.34.0 milestone Nov 2, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧨

@manicminer manicminer merged commit 9216541 into main Nov 3, 2021
@manicminer manicminer deleted the bugfix/msi-cloudshell branch November 3, 2021 21:39
manicminer added a commit that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSI support in Azure Cloud Shell
2 participants