Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reintroduce the uninstall command #3650

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: Reintroduce the uninstall command #3650

merged 2 commits into from
Dec 4, 2024

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Dec 3, 2024

Fix #3648.

@jjerphan jjerphan changed the title fix: Reintroduce the uninstall command fix: Reintroduce the uninstall command Dec 3, 2024
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Dec 3, 2024
@jjerphan jjerphan marked this pull request as ready for review December 3, 2024 13:37
jjerphan
jjerphan commented Dec 3, 2024
View reviewed changes
micromamba/src/umamba.cpp Outdated Show resolved Hide resolved
@jjerphan jjerphan force-pushed the fix/reintroduce-uninstall-command branch 2 times, most recently from 81ea936 to a92401c Compare December 3, 2024 14:42
@jjerphan jjerphan force-pushed the fix/reintroduce-uninstall-command branch from a92401c to aa71ff9 Compare December 3, 2024 15:09
JohanMabille
JohanMabille requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thing using an alias instead of adding a new subcommand would be better.

@jjerphan
Simply add a subcommand
fb3c0ca 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan requested a review from JohanMabille December 4, 2024 13:23
@JohanMabille JohanMabille merged commit 575809f into mamba-org:main Dec 4, 2024
34 checks passed
@jjerphan jjerphan deleted the fix/reintroduce-uninstall-command branch December 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mamba uninstall not recognized as alias to mamba remove
2 participants
@jjerphan @JohanMabille