Reduce number of warnings #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanm
reviewed
Dec 13, 2024
| @@ -45,7 +45,7 @@ class CTable | |||
|
|
|||
| CTable() | |||
| { | |||
| ::memset(_rgtype, 0, sizeof(_rgtype)); | |||
| ::memset((void*)_rgtype, 0, sizeof(_rgtype)); | |||
There was a problem hiding this comment.
Wait, this isn't fixing anything, it's just suppressing the warning... and the warning looks correct to me.
seanm
reviewed
Dec 13, 2024
Utilities/socketxx/socket++/fork.cpp
Outdated
Comment on lines
40
to
48
| { | ||
| ForkProcess* cur = Fork::ForkProcess::list; | ||
| while(cur != nullptr){ | ||
| ForkProcess* next = cur->next; | ||
| if(cur->kill_child) | ||
| delete cur; | ||
| break; | ||
| } | ||
|
|
||
| cur = next; | ||
| } | ||
There was a problem hiding this comment.
The commit message doesn't say what the change is about...
seanm
reviewed
Dec 13, 2024
| @@ -607,7 +607,7 @@ class Element<TVR, VM::VM1_n> | |||
| Save = true; // ???? | |||
| if( Internal ) | |||
| { | |||
| memcpy(internal, Internal, len); | |||
| memcpy((void*)internal, (void*)Internal, Length); | |||
There was a problem hiding this comment.
Same comment here. This is suppressing a warning, not fixing anything...
seanm
reviewed
Dec 13, 2024
Utilities/socketxx/socket++/fork.cpp
Outdated
Comment on lines
38
to
46
| // First, kill all children whose kill_child flag is set. | ||
| // Second, wait for other children to die. | ||
| { | ||
| for (ForkProcess* cur = Fork::ForkProcess::list; cur; cur = cur->next) | ||
| if (cur->kill_child) | ||
|
|
||
| for (ForkProcess* cur = Fork::ForkProcess::list; cur != nullptr; cur = cur->next) | ||
| if (cur->kill_child) { | ||
| delete cur; | ||
| break; | ||
| } |
There was a problem hiding this comment.
The comment above this code says "kill all children" so breaking after killing one seems wrong...
seanm
reviewed
Dec 13, 2024
| @@ -58,7 +58,7 @@ unique_ptr<JpegMarkerSegment> JpegMarkerSegment::CreateJpegFileInterchangeFormat | |||
| content.push_back(static_cast<uint8_t>(params.Ythumbnail)); | |||
| if (params.Xthumbnail > 0) | |||
| { | |||
| if (params.thumbnail) | |||
There was a problem hiding this comment.
This is 3rd party code, so needs separate handling.
Is this reversal of logic fixed upstream already perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of: -Wclass-memaccess -Wuse-after-free -Werror=unused-but-set-variable -Werror=unused-variable -Werror=nonnull for GCC 12.
This PR is updated #177.