Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for compression of HTTP responses #61

Closed
danielwhite opened this issue Sep 4, 2015 · 5 comments
Closed

Support for compression of HTTP responses #61

danielwhite opened this issue Sep 4, 2015 · 5 comments

Comments

@danielwhite
Copy link

We're using MailHog for testing in an environment where testers and deployments are geographically distributed.

When the inbox has more than 50 messages, then refreshing the inbox can result in a response that can be 10MB or more. With compression, this reduces the response for a full 50 messages to a few hundred KB.

While we could put MailHog behind a real web-server, this would be an extra complexity that detracts from it being a simple drop-in solution.

This issue is primarily for visibility, and the relevant pull requests to support this are:

@ian-kent
Copy link
Member

ian-kent commented Oct 6, 2015

thanks @danielwhite 👍 merges are done so should work if building from source, or it'll be in the next release!

@ian-kent ian-kent closed this as completed Oct 6, 2015
ian-kent added a commit to mailhog/http that referenced this issue Oct 6, 2015
breaks event source, no obvious reason (possibly gzip writer
closing when handler func returns, but preventing that didn't help)

reopens mailhog/MailHog#61
@ian-kent
Copy link
Member

ian-kent commented Oct 6, 2015

compression seems to break the event source connection, taking it back out while I investigate

@ian-kent ian-kent reopened this Oct 6, 2015
@danielwhite
Copy link
Author

Ouch. Sorry I didn't spot that. I'm happy to track down and fix the problem if nothing obvious has jumped out already.

@ian-kent
Copy link
Member

I haven't had a chance to look properly yet, it may well be an issue with goose rather than MailHog - but yeah I'd appreciate it if you do have time to investigate!

@tyndyll
Copy link
Member

tyndyll commented Feb 19, 2019

Closing this. There are other issues here that suggest extracting out attachments that I think may be the better solution to the problem for now

@tyndyll tyndyll closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants