Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump buffer-alloc to 1.2.0 and to-buffer to 1.1.1 #91

Merged
merged 1 commit into from
Sep 22, 2018
Merged

Bump buffer-alloc to 1.2.0 and to-buffer to 1.1.1 #91

merged 1 commit into from
Sep 22, 2018

Conversation

jake-low
Copy link
Contributor

I've been seeing warnings for a while when using the Yarn package manager about the Buffer constructor API being deprecated in favor of Buffer.from and Buffer.alloc.

Yarn depends on tar-stream, and two of tar-stream's dependencies use new Buffer, but happily newer versions of both those dependencies exist that check if the appropriate new API is available and use that instead.

  • buffer-alloc 1.2.0 bumps its dependency on buffer-fill to 1.0.0, which includes a new check for Buffer.alloc
  • to-buffer 1.1.1 checks for Buffer.from and uses it if it's available. Also I just realized to-buffer is also your project so you knew that already 🙂

I ran the tar-stream tests on my machine, and they passed. After that I used yarn link to pull my modified version of tar-stream into my local copy of Yarn, and found that this fixed the deprecation warnings. So once you merge this PR and release a new version of tar-stream, I'll make a PR to Yarn to bump the tar-stream version there, and that should make the message go away for Yarn users.

Cheers!
-Jake

@mafintosh mafintosh merged commit e7ec711 into mafintosh:master Sep 22, 2018
@mafintosh
Copy link
Owner

1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants