Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added firefox & IE support + fixed callback not firing. #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added firefox & IE support + fixed callback not firing. #9

wants to merge 6 commits into from

Conversation

gijsroge
Copy link

  • This will add support for Firefox and Internet Explorer.
  • Add a check if scroll reached bottom page to trigger callback

This was referenced May 22, 2015
Open
Open
@gijsroge gijsroge closed this May 23, 2015
@gijsroge gijsroge reopened this May 23, 2015
@gijsroge gijsroge mentioned this pull request May 23, 2015
Open
@gijsroge gijsroge changed the title detect if browser supports document.body or document.documentElement detect if browser supports document.body or document.documentElement & fixed callback not firing in some cases May 23, 2015
@gijsroge gijsroge changed the title detect if browser supports document.body or document.documentElement & fixed callback not firing in some cases Added firefox & IE support + fixed callback not firing. May 23, 2015
@gijsroge
Copy link
Author

Note: removed the hardcoded fix for scrolling with the body element. You should include this polyfill to fix the issue -> https://github.com/mathiasbynens/document.scrollingElement

@derek-schultz
Copy link

Why was this never merged? Does it still work?

@gijsroge
Copy link
Author

gijsroge commented Apr 4, 2017

@derek-schultz Probably because they are busy which is perfectly reasonable, in the mean time you can use my fork. https://github.com/gijsroge/animated-scrollto

@nikoloza
Copy link

@gijsroge I used your repository as replacing NPM package of this one, but it still does not work on FF

@gijsroge
Copy link
Author

@nikoloza Did you add the scollingElement polyfill? See: https://github.com/gijsroge/animated-scrollto#browser-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gijsroge @derek-schultz @nikoloza @afisher88