Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Downgrade to llvm-4.0 #1487

Merged
merged 1 commit into from
Mar 28, 2018
Merged

rust: Downgrade to llvm-4.0 #1487

merged 1 commit into from
Mar 28, 2018

Conversation

raimue
Copy link
Member

@raimue raimue commented Mar 27, 2018

The update to 1.24.0 in 4b2c24c erroneously switched to LLVM 5.0, which
is still not supported by this rust version. Compiling with rustc will
produce "invalid expression" messages.

See: rust-lang/rust#43370
See: rust-lang/rust#47464

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

I did not test to build it.

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

The update to 1.24.0 in 4b2c24c erroneously switched to LLVM 5.0, which
is still not supported by this rust version. Compiling with rustc will
produce "invalid expression" messages.

See: rust-lang/rust#43370
See: rust-lang/rust#47464
@macportsbot
Copy link

Notifying maintainers:
@g5pw for port rust.

@macportsbot
Copy link

Travis Build #1808 Errored.

Lint results
--->  Verifying Portfile for rust
--->  0 errors and 0 warnings found.

The build timed out.

@seanfarley
Copy link
Contributor

Looks ok to me.

@pmetzger
Copy link
Member

The rust port is sufficiently important, and the fix is sufficiently simple, that I'm wondering if this falls under the "A critical port is broken that affects many users" exception to committing to a port that isn't openmaintainer in less than 72 hours.

@g5pw any comments? Also, would you be willing to make this "openmaintainer" so there is less ambiguity about fixing small issues going forward?

@g5pw g5pw merged commit 87c7512 into macports:master Mar 28, 2018
@g5pw
Copy link
Contributor

g5pw commented Mar 28, 2018

No comments, thanks for the pull request, sorry for the delay.

@pmetzger
Copy link
Member

@g5pw What do you think of making rust openmaintainer?

@g5pw
Copy link
Contributor

g5pw commented Mar 28, 2018

It's fine by me, as my time for MacPorts seems to be constantly shrinking :/

@raimue raimue deleted the rust-llvm4 branch April 10, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants