rust: update to 1.23.0 #1228
rust: update to 1.23.0 #1228
Conversation
|
Notifying maintainers: |
|
Oh, wow, thanks for the work on this! It has been sitting on my todo list of an embarrassing amount of time. The patch looks fine, just one question: why did you remove the rust-src subport? It's needed for some binaries like |
|
No particular reason really, I just wasn't sure if it would work as is and don't know much about subports. Looking at it now, it seems like I can put it back as-is. I'll try it and see. |
|
Added |
|
@g5pw Can this be merged? (The travis build didn't actually fail, Travis is having problems.) |
|
@pmetzger Yes, I'm aware, the rust build is pretty long. I have some comments inline, but I guess that piece of code is not that important. I'll add it back and merge manually. |
|
@g5pw ? |
|
I tried building the port on my machine, but it fails. does it build for you @pmetzger ? EDIT: Please disregard that, it may have been a spurious error. I'm rebuilding now, if it installs correctly I'm pushing it with some modifications. |
|
Thank you! Can I leave it to you to close the PR? |
|
Sure thing! |
|
Merged in 29f98d8. @mohd-akram, thanks for your contribution to MacPorts! |
|
And thank you, @g5pw! |
| } | ||
| } | ||
| + | ||
| +#[link(name = "ffi")] extern {} |
There was a problem hiding this comment.
What does this patch do? Can you add some comments in this file or before patchfiles in the Portfile?
There was a problem hiding this comment.
I believe I got it from rust-lang/rust#34486.
|
BTW, it's almost certainly time for an update to a much newer Rust... |
Description
Update rust to 1.23.0. Essentially a rewrite so I simplified things a bit, but it works. Uses MacPorts' LLVM instead of the bundled one for a (relatively) faster build.
Tested on
macOS 10.13.2 17C88
Xcode 9.2 9C40b
Verification
Have you
port lint?sudo port test?sudo port -vst install?