Check for null pointer dereference #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of Activate should be checked. It may return NULL as described in https://learn.microsoft.com/en-us/windows/win32/api/mmdeviceapi/nf-mmdeviceapi-immdevice-activate This will prevent a null pointer dereference when the Activate function fails. Fixes m1dugh#42 and see m1dugh#42 for details.
JJ-8
changed the title
|
Hello, this looks good to me, thanks for the PR, sorry I couldn't make the change myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @m1dugh, since this issue is quite severe for our users I have already made a proposal to fix this problem. However I have NOT tested this at all since I am unable to reproduce this problem and don't have a development environment for your project. So could you verify that this fix is correctly implemented? Thank you in advance.
Change:
The result of Activate should be checked. It may return NULL as described in https://learn.microsoft.com/en-us/windows/win32/api/mmdeviceapi/nf-mmdeviceapi-immdevice-activate This will prevent a null pointer dereference when the Activate function fails. Fixes #42 and see #42 for details.