add NewTabWidgetWithStyle() #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables a user to apply these styles to a tab widget: https://docs.microsoft.com/en-us/windows/desktop/Controls/tab-control-styles - follows the convention of other functions in this package like NewCompositeWithStyle and NewListBoxWithStyle
|
Are there other useful styles? Why not instead expose this as SetMultiline(true)? |
dayvonjersen
added a commit
to dayvonjersen/chopsuey
that referenced
this pull request
Sep 3, 2023
- gofmt decided my comments weren't formatted properly I guess - replace all calls to win.MustLoadLibrary() and win.MustGetProcAddress() thanks to lxn/win@e90c084 annoying af tbh - my PR for NewTabWidgetWithStyle lxn/walk#402 never got merged in any way and since go modules made $GOPATH useless, there's no easy way to get multiline tabs right now so I just disabled them. I'll fork the repo later or something. - added a nil pointer check which fixes one (1) of the crashes - some widgets now have ~20px of padding which is annoying - this whole codebase is a superfund site tbh might be better off rewriting the whole thing from scratch including writing my own IRC lib, I suspect goirc's async nature is what has caused all the complexity ""requiring"" tabManager and mw.Synchronize calls and so forth. It's also possible the multiline tabs are buggy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enables a user to apply these styles to a tab widget:
https://docs.microsoft.com/en-us/windows/desktop/Controls/tab-control-styles
follows the convention of other functions in this package
like NewCompositeWithStyle and NewListBoxWithStyle