Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#447: Add show_versions helper for debugging #450

Merged
merged 7 commits into from
Feb 7, 2022
Merged

Conversation

cgarciae
Copy link
Contributor

Overview

Adds a show_versions() function that prints the lux, pandas, and luxwidget versions. We can ask for this information for debugging.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #450 (7b5a38f) into master (a7e2cf7) will decrease coverage by 0.15%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   65.65%   65.49%   -0.16%     
==========================================
  Files          55       56       +1     
  Lines        4440     4460      +20     
==========================================
+ Hits         2915     2921       +6     
- Misses       1525     1539      +14     
Impacted Files Coverage Δ
lux/utils/debug_utils.py 26.31% <26.31%> (ø)
lux/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e2cf7...7b5a38f. Read the comment docs.

@dorisjlee
Copy link
Member

dorisjlee commented Jan 30, 2022

Thanks Cristian! Several suggested minor fixes on show_version, but otherwise looks good. I think show_version and some of the other functions in #451 can be called via a user-facing "debug" function. That could be a separate PR or part of #451. Once we have that, we should also add instructions in the troubleshooting guide on what the users would have to call to trigger the debug messages.

lux/utils/debug_utils.py Show resolved Hide resolved
lux/utils/debug_utils.py Show resolved Hide resolved
lux/utils/debug_utils.py Show resolved Hide resolved
lux/utils/debug_utils.py Outdated Show resolved Hide resolved
@dorisjlee
Copy link
Member

dorisjlee commented Jan 30, 2022

Please edit the PR title so that it is formatted based on the commit guidelines (e.g., DOCS-#...: commit message)

@cgarciae cgarciae changed the title Add show_versions helper for debugging FIX-#447: Add show_versions helper for debugging Feb 3, 2022
@cgarciae
Copy link
Contributor Author

cgarciae commented Feb 3, 2022

Hey @dorisjlee! Sounds good, lux.debug could aggregate information from all these functions. Once this are merge that would be easy.

@cgarciae
Copy link
Contributor Author

cgarciae commented Feb 3, 2022

@dorisjlee added packages info from jupyter --version

@dorisjlee dorisjlee merged commit a402c49 into master Feb 7, 2022
@dorisjlee
Copy link
Member

Looks good! Thanks @cgarciae!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants