FIX-#398: Add fix for pandas 1.3 #428
Conversation
Signed-off-by: Kunal Agarwal <[email protected]>
Signed-off-by: Kunal Agarwal <[email protected]>
Signed-off-by: Kunal Agarwal <[email protected]>
Signed-off-by: Kunal Agarwal <[email protected]>
Signed-off-by: Doris Lee <[email protected]>
dorisjlee
force-pushed
the
pandas-ver-bump
branch
from
6b52f37 to
7820fc2
Compare
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
- Coverage 65.96% 65.55% -0.41%
==========================================
Files 55 55
Lines 4416 4419 +3
==========================================
- Hits 2913 2897 -16
- Misses 1503 1522 +19
Continue to review full report at Codecov.
|
Signed-off-by: Doris Lee <[email protected]>
|
This looks great, thanks @westernguy2! |
| @@ -1,7 +1,7 @@ | |||
| scipy>=1.3.3 | |||
| altair>=4.0.0 | |||
| numpy>=1.16.5 | |||
| pandas>=1.2.0,<1.3.0 | |||
| pandas | |||
There was a problem hiding this comment.
I've also updated the requirements to require
pandas>= 1.3.0
There seems to be no minimum bound here?
There was a problem hiding this comment.
I agree that enforcing the pandas>=1.3.0 would be useful here, we originally took this out because we didn't want to force users into updating their pandas version from 1.2 to 1.3 because of their updates to Lux.
@westernguy2, @cgarciae : Would love to get your thoughts on this! With this PR fix, my understanding is that we no longer support pandas<1.3? Does using pandas 1.2 cause errors in Lux or fail silently?
There was a problem hiding this comment.
The PR fix does now support the most up to date version of pandas and pandas<1.3. In lux/core/__init__, I check for the version, so the correct variable assignment is completed based on the version.
pandas 1.2 should work as expected
There was a problem hiding this comment.
Got it, thanks @westernguy2 !
Signed-off-by: Kunal Agarwal [email protected]
Overview
Pandas 1.3.x changes the file structure of
pd.io.parsers. As a result, in order to read any data in as a LuxDataFrame, the following change must be made.Changes
I've changed
__init__to account for the new file structure mentioned above. I've also updated the requirements to requirepandas>= 1.3.0since the change will cause Lux to break on any Pandas version below 1.3.0.Currently 3 tests are failing due to a different update in Pandas 1.3.x which causing history to not propagate in some instances.
Example Output
The example given in #398 displays the Lux widget as expected now.