Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError bugfix for matplotlib bar chart #391

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

dorisjlee
Copy link
Member

@dorisjlee dorisjlee commented Jun 25, 2021

This PR fixes the issue in #380. In addition, this PR includes several fixes to matplotlib code exports.

@dorisjlee dorisjlee changed the title matplotlib bar chart bugfix KeyError bugfix for matplotlib bar chart Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #391 (dfabe0b) into master (29e0c70) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   84.91%   84.93%   +0.02%     
==========================================
  Files          52       52              
  Lines        4024     4030       +6     
==========================================
+ Hits         3417     3423       +6     
  Misses        607      607              
Impacted Files Coverage Δ
lux/vislib/matplotlib/BarChart.py 92.59% <100.00%> (+0.38%) ⬆️
lux/vislib/matplotlib/LineChart.py 88.73% <100.00%> (+0.16%) ⬆️
lux/vislib/matplotlib/ScatterChart.py 76.74% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e0c70...dfabe0b. Read the comment docs.

@dorisjlee dorisjlee merged commit 2b6e162 into lux-org:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant