Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geographic types documentation #358

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

micahtyong
Copy link
Member

Overview

In this PR, we provide concise documentation for #253, geographic data types.

Changes

  • New documentation page, source/advanced/map.rst
  • Citing geographic tutorial in FAQ.rst
  • Adding as new tab in index.rst

Example Output

After running make html in the doc/ folder then opening the documentation to the new page, we should see the following (subject to change):

Screen Shot 2021-04-14 at 10 13 23 AM

@micahtyong micahtyong requested a review from dorisjlee April 14, 2021 17:14
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #358 (2684a14) into master (939799f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          51       51           
  Lines        3884     3884           
=======================================
  Hits         3274     3274           
  Misses        610      610           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939799f...2684a14. Read the comment docs.

@dorisjlee dorisjlee merged commit eab1982 into lux-org:master Apr 15, 2021
@dorisjlee
Copy link
Member

Thanks @micahtyong, I made some writing changes, but otherwise everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants