Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in test and data type inference code #349

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

dorisjlee
Copy link
Member

Overview

Fixing various bugs and inconsistent logic in data type inference.

  • remove unnecessary convert_dtype in float inference (previously added to make integer columns with NaNs detectable as floats, now switch to cardinality cutoff for all)
  • bring back cardinality calculation on all float columns (removing the need for special value 999 on float cardinality)
  • nominal detection applies even for floats < 20 rows (and associated test changes)

* remove expensive convert_dtype in float inference
* bring back cardinality calculation on all float columns
* nominal detection applies even for floats < 20 row now
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #349 (2fca0c7) into master (1a72332) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2fca0c7 differs from pull request most recent head 4ffb277. Consider uploading reports for the commit 4ffb277 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   79.98%   79.99%   +0.01%     
==========================================
  Files          50       50              
  Lines        3612     3609       -3     
==========================================
- Hits         2889     2887       -2     
+ Misses        723      722       -1     
Impacted Files Coverage Δ
lux/executor/PandasExecutor.py 95.97% <100.00%> (-0.05%) ⬇️
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (ø)
lux/vislib/matplotlib/Heatmap.py 96.66% <0.00%> (ø)
lux/vislib/matplotlib/ScatterChart.py 75.29% <0.00%> (ø)
lux/vislib/altair/ScatterChart.py 96.96% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a72332...4ffb277. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant