-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"All-column" vis when only few columns in dataframe #199 #336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 84.39% 84.44% +0.04%
==========================================
Files 51 51
Lines 3891 3902 +11
==========================================
+ Hits 3284 3295 +11
Misses 607 607
Continue to review full report at Codecov.
|
0769f25
to
89c206d
Compare
Hi @caitlynachen, Thanks for the PR! The all-column visualization looks much better than the recommendations that we had before! This is especially true when we filter to only 2 or 3 columns in a dataframe. Here are some examples of this: I was playing around with this feature and had a couple of suggestions on what we can do to improve this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Maybe we can extend this feature to the entire dataframe and set a global config like small_dataframe_ok
or show_all_data_columns
depending on the use-case you were thinking of!
…ales (#262) * Add support to improve temporal action to display different timescales * Resolve PR comments * Add support to improve temporal action to display different timescales * Resolve PR comments * Reformat files using black * "All-column" vis when only few columns in dataframe #199 (#336) Co-authored-by: Caitlyn Chen <[email protected]> Co-authored-by: Doris Lee <[email protected]> * documentation and cleaning * added notebook gallery * update README * removed scatterplot message in SQLExecutor * fixed typo in SQL documentation * update README and bump version * bump version * clear propagated vis data intent after PandasExecutor completes execute (#297) * fix black to stable version * Scalability: incorporate early pruning optimizations (#368) * changes from perf branch to config * added flag for turning on/off lazy maintain optimization * merged in approx early pruning code * increase overall sampling start and cap * Adjust width and length criteria for early pruning vislist based on experiment results; Add warning message and test for early pruning * black version update * version lock on black * * fixed sql tests (added approx to execute constructor) * fixed sampling config test * improved Executor documentation * timescale feature * adding weekday * adding docs * bugfix for y axis line chart export * fixing temporal axis by adding timescale variable in Clause Co-authored-by: Doris Lee <[email protected]> Co-authored-by: Caitlyn Chen <[email protected]> Co-authored-by: Caitlyn Chen <[email protected]>
Overview
Current-vis: "All-column" vis when only few columns in dataframe #199
Changes
If dataframe has only 2 or 3 columns, use current_vis to show an all-column visualization
Example Output