-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Altair] Sync exported histogram code with new bin determination #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o binned-charts
micahtyong
changed the title
Binned charts
[Altair] Sync exported histogram code with new bin determination
Mar 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 77.58% 81.08% +3.50%
==========================================
Files 40 50 +10
Lines 2846 3569 +723
==========================================
+ Hits 2208 2894 +686
- Misses 638 675 +37
Continue to review full report at Codecov.
|
Thanks @micahtyong ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Closes #302 by syncing up the new histogram bin determination rules from #285 into the Altair exported code.
Changes
altair/Histogram.py
andtest_vis.py
Example Output
Employee Dataset: Distribution
Following the example in #302, upon running,
then exporting our graph,
we now get the following output:
Olympic Dataset: Occurrence
The output is also as expected for displaying categorical distributions using the y-axis. For example, running
then selecting the second graph from the Occurrence tab and exporting with
we now get the following output: