Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added axis name for unnamed Series visualization #263

Merged
merged 8 commits into from
Feb 17, 2021

Conversation

caitlynachen
Copy link
Contributor

@caitlynachen caitlynachen commented Feb 12, 2021

For histograms with no column name attribute, use "Series" as a placeholder.
" " -> "Series (binned)"

Screen Shot 2021-02-11 at 10 19 15 PM

Screen Shot 2021-02-11 at 10 19 05 PM

https://app.zenhub.com/workspaces/lux-board-6000bc7686a00400181b23f3/issues/lux-org/lux/241

@dorisjlee
Copy link
Member

dorisjlee commented Feb 13, 2021

Thanks @caitlynachen ! Could you add a test case for this and provide a more detailed description for the PR?

tests/test_vis.py Outdated Show resolved Hide resolved
lux/vislib/matplotlib/Histogram.py Outdated Show resolved Hide resolved
@caitlynachen
Copy link
Contributor Author

should be built on top of #266

@dorisjlee dorisjlee merged commit f745fb9 into lux-org:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants