Adding Long Descriptions #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorisjlee
requested changes
Jan 26, 2021
jakeatgalileo
approved these changes
Jan 26, 2021
|
@dorisjlee I can change the adaptive fields, but there were some other cases, where I was a bit confused with the long description. I will schedule some time to sync with you on this. |
dorisjlee
reviewed
Feb 13, 2021
dorisjlee
reviewed
Feb 14, 2021
lux/action/column_group.py
Outdated
| @@ -26,6 +26,7 @@ def column_group(ldf): | |||
| recommendation = { | |||
| "action": "Column Groups", | |||
| "description": "Shows charts of possible visualizations with respect to the column-wise index.", | |||
| "long_description": "Shows charts of possible visualizations with respect to the column-wise index.", | |||
There was a problem hiding this comment.
Might want to expand on this description with an image or longer description and link to the description on this page.
There was a problem hiding this comment.
@dorisjlee Added some descriptions (I'm not a fan of the images there, but we can chat about that more) as well as a link.
lux/action/row_group.py
Outdated
| @@ -26,6 +26,7 @@ def row_group(ldf): | |||
| recommendation = { | |||
| "action": "Row Groups", | |||
| "description": "Shows charts of possible visualizations with respect to the row-wise index.", | |||
| "long_description": "Shows charts of possible visualizations with respect to the row-wise index.", | |||
There was a problem hiding this comment.
same comment as column_group.py
There was a problem hiding this comment.
same as above
dorisjlee
approved these changes
Feb 17, 2021
|
Thanks @jerrysong1324 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Lux Issue #216
Related to Lux Widget PR 67