Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Make df.data_type a property that accesses df._data_type #231

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

jinimukh
Copy link
Member

Before, the user could change df.data_type by setting it to some other dictionary. This would benefit from being a "protected variable". Thus, df.data_type is a property getter for df._data_type.

Also, df.data_type only returned a non-null dictionary if df._repr_html() was called before. Now, the getter calls df.maintain_metadata() if df._data_type is null.

Changed:

  • changed metadata attribute df.data_type to df._data_type
  • added a getter that calls df.maintain_metadata if df._data_type is NULL

lux/core/frame.py Outdated Show resolved Hide resolved
@dorisjlee
Copy link
Member

This looks good @jinimukh, could you resolve the comment and branch conflict before we merge? Thanks!

@dorisjlee dorisjlee merged commit 91d6025 into lux-org:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants