Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/366 tx history improvements #966

Merged
merged 9 commits into from
Jul 24, 2018
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jul 13, 2018

Closes #366

Description:

Based on the SDK 0.20 branch.

❤️ Thank you!

@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Jul 13, 2018
@faboweb faboweb requested review from NodeGuy and nylira as code owners July 13, 2018 12:51
@faboweb faboweb removed the blocked ✋ issues blocked by other implementations/issues label Jul 16, 2018
@faboweb faboweb changed the title Fabo/366 tx history improvements WIP: Fabo/366 tx history improvements Jul 18, 2018
@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #966 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #966   +/-   ##
========================================
  Coverage    96.32%   96.32%           
========================================
  Files           82       82           
  Lines         1524     1524           
  Branches        77       77           
========================================
  Hits          1468     1468           
  Misses          49       49           
  Partials         7        7
Impacted Files Coverage Δ
...rc/renderer/components/wallet/PageTransactions.vue 100% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClientMock.js 95.19% <ø> (ø) ⬆️

@NodeGuy
Copy link
Contributor

NodeGuy commented Jul 20, 2018

How's everything going with this?

@faboweb
Copy link
Collaborator Author

faboweb commented Jul 21, 2018

Didn't have time to work on this. Hopefully have time to work on this next week.

Voyager Bot added 4 commits July 24, 2018 11:11
Conflicts:
	CHANGELOG.md
	app/src/renderer/connectors/lcdClientMock.js
	tasks/build/Gaia/COMMIT.sh
	test/unit/specs/components/wallet/PageTransactions.spec.js
@faboweb faboweb changed the title WIP: Fabo/366 tx history improvements Fabo/366 tx history improvements Jul 24, 2018
@faboweb faboweb requested a review from fedekunze July 24, 2018 09:51
@faboweb faboweb merged commit 9fe2d7e into develop Jul 24, 2018
@faboweb faboweb deleted the fabo/366-tx-history-improvements branch July 24, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use real transaction UIDs
3 participants