peng/468 password confirm

[nylira]

• add password confirmation field to NiSessionSignUp
• add password confirmation field to NiSessionImport
• add unit tests for new code

Issue

closes: #468

Screenshots

[nylira]

It appears the integration test is failing?

# logs in
unhandledRejection { Error: element ("#app-content") still not existing after 5000ms
  message: 'element ("#app-content") still not existing after 5000ms',
  type: 'WaitUntilTimeoutError' }

[faboweb]

Could you please recheck, that this an actual bug and not a semantic error? -> Is #app-content actual showing following the log in steps in the E2E tests? Probably they need to be updated with the new password confirmation step.

[nylira]

Haven't had time to look at this. It seems like you're probably correct @faboweb, the extra password confirmation step has to be mocked in the e2e test

[codecov]

Codecov Report

Merging #532 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #532     +/-   ##
==========================================
+ Coverage    81.46%   81.56%   +0.1%     
==========================================
  Files           84       84             
  Lines         1365     1367      +2     
  Branches        67       67             
==========================================
+ Hits          1112     1115      +3     
+ Misses         241      240      -1     
  Partials        12       12

Impacted Files	Coverage Δ
...src/renderer/components/common/NiSessionSignUp.vue	100% <ø> (ø)	⬆️
...src/renderer/components/common/NiSessionImport.vue	100% <100%> (ø)	⬆️
app/src/renderer/components/common/NiFormMsg.vue	60.86% <0%> (+4.34%)	⬆️

[faboweb]

will be green after #543

[jbibla]

@nylira @faboweb still failing...

[faboweb]

different error. I check it out.

[faboweb]

#magic