Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peng/bonding changes #478

Merged
merged 15 commits into from
Feb 16, 2018
Merged

Peng/bonding changes #478

merged 15 commits into from
Feb 16, 2018

Conversation

nylira
Copy link
Contributor

@nylira nylira commented Feb 14, 2018

Your checklist for this pull request

  • Make sure you are requesting to pull your feature/bugfix branch (right side).
  • Make sure you are making a pull request against the develop branch (left side). Also make sure to start your branch off our develop.
  • If this PR produces a visible change, please provide screenshots showing these changes.
  • Confirm that your pull request will pass our linting and unit tests.
  • Make sure your code is properly tested, so that the code coverage is not decreasing.

Changes checklist

  • on PageDelegates, delegates that the user have bonded to before are automatically checked and locked for use on PageBond. Because it doesn't make sense to allow the user to only bond a portion of their atoms, and it'll be confusing when it shows them that they only have a few unbonded atoms left.
  • bonding bar width is limited to remaining user atoms when increasing bonded atoms via the numerical input field
  • numerical input field for atoms per delegate has a min and max limit so that clicking the up and down arrows for the field don't pass 0 or max
  • resolve bonding bar width bug where it scales out of control
  • resolve lack of unbonding message

Screenshots

The screenshot below shows what happens on PageDelegates on initial load, if the user has already delegated atoms in the past. Those validators are already checked and cannot be unchecked. If they want to 'uncheck' those validators they have to unbond from them first.

screen shot 2018-02-14 at 4 22 55 pm

Issue

Closes #453
Closes #455

@nylira nylira requested a review from mappum as a code owner February 14, 2018 08:12
@nylira
Copy link
Contributor Author

nylira commented Feb 14, 2018

I'm out of time to work further on this. I have notes on #453, the out of control bonding bar problem.

This bug is caused by the fact that this.fields.delegates is either undefined or defined as an empty array on this line: https://github.com/cosmos/voyager/blob/d947837db2c6df37145d6d83f1fc1ac6baae91ac/app/src/renderer/components/staking/PageBond.vue#L296. Because the function cannot find the correct delegate, the bar width has no limit, so it goes crazy.

I'm not sure why this.fields.delegates is undefined there, because when the page is mounted, this.fields.delegates seems to be already defined.

@faboweb
Copy link
Collaborator

faboweb commented Feb 14, 2018

@faboweb
Copy link
Collaborator

faboweb commented Feb 14, 2018

@jolesbi can u take "resolve lack of unbonding message"?

@jbibla
Copy link
Collaborator

jbibla commented Feb 15, 2018

done.

@faboweb faboweb changed the title WIP: Peng/bonding changes Peng/bonding changes Feb 16, 2018
@faboweb faboweb merged commit 689f950 into develop Feb 16, 2018
@faboweb faboweb deleted the peng/bonding-changes branch February 16, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbonding should show different message than when bonding PageBond UI error
3 participants