Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not used files #466

Merged
merged 5 commits into from
Feb 12, 2018
Merged

Remove not used files #466

merged 5 commits into from
Feb 12, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Feb 12, 2018

Your checklist for this pull request

  • Make sure you are requesting to pull your feature/bugfix branch (right side).
  • Make sure you are making a pull request against the develop branch (left side). Also make sure to start your branch off our develop.
  • If this PR produces a visible change, please provide screenshots showing these changes.
  • Confirm that your pull request will pass our linting and unit tests.
  • Make sure your code is properly tested, so that the code coverage is not decreasing.

Issue

Please provide the #123 of the issue you created in advance, that describes the bug/proposed change.
#462

❤️Thank you!

@codecov
Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #466 into develop will increase coverage by 1.19%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
+ Coverage     77.5%   78.69%   +1.19%     
===========================================
  Files           85       81       -4     
  Lines         1338     1319      -19     
  Branches        68       66       -2     
===========================================
+ Hits          1037     1038       +1     
+ Misses         283      263      -20     
  Partials        18       18
Impacted Files Coverage Δ
app/src/renderer/scripts/num.js 100% <100%> (+86.95%) ⬆️

@jbibla jbibla merged commit 227c153 into develop Feb 12, 2018
@jbibla jbibla deleted the fabo/462-cleanup branch February 12, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants