Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2330 poquito requests 2 #2333

Merged
merged 8 commits into from
Mar 24, 2019
Merged

Fabo/2330 poquito requests 2 #2333

merged 8 commits into from
Mar 24, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 22, 2019

Closes #2330

Moved throttling of requests into modules.
Properly query once initially and then every 10 blocks.
Also throttling validator (list and signing info updates).

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #2333 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2333      +/-   ##
===========================================
+ Coverage    97.07%   97.08%   +<.01%     
===========================================
  Files          105      105              
  Lines         2325     2330       +5     
  Branches       127      124       -3     
===========================================
+ Hits          2257     2262       +5     
  Misses          57       57              
  Partials        11       11
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/delegates.js 98.03% <100%> (+0.12%) ⬆️
app/src/renderer/vuex/modules/distribution.js 100% <100%> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 96.15% <100%> (-0.28%) ⬇️
app/src/renderer/vuex/getters.js 91.07% <100%> (+0.5%) ⬆️
.../src/renderer/components/staking/TabValidators.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/common/TmBalance.vue 100% <100%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #2333 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2333      +/-   ##
===========================================
+ Coverage    97.06%   97.07%   +<.01%     
===========================================
  Files          105      105              
  Lines         2320     2325       +5     
  Branches       127      124       -3     
===========================================
+ Hits          2252     2257       +5     
  Misses          57       57              
  Partials        11       11
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/delegates.js 98.03% <100%> (+0.12%) ⬆️
app/src/renderer/vuex/getters.js 91.07% <100%> (+0.5%) ⬆️
app/src/renderer/vuex/modules/distribution.js 100% <100%> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 96.15% <100%> (-0.28%) ⬇️
.../src/renderer/components/staking/TabValidators.vue 100% <100%> (ø) ⬆️
...rc/renderer/components/wallet/PageTransactions.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/common/TmBalance.vue 100% <100%> (ø) ⬆️

@faboweb faboweb marked this pull request as ready for review March 24, 2019 15:19
@faboweb faboweb requested review from jbibla and sabau as code owners March 24, 2019 15:19
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fix required

app/src/renderer/vuex/modules/delegates.js Outdated Show resolved Hide resolved
app/src/renderer/components/common/TmBalance.vue Outdated Show resolved Hide resolved
app/src/renderer/vuex/modules/distribution.js Outdated Show resolved Hide resolved
@faboweb faboweb merged commit bf28951 into develop Mar 24, 2019
@faboweb faboweb deleted the fabo/2330-poquito-requests-2 branch March 24, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards not updated
2 participants