Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix atoms <––> uatoms conversion #2274

Merged
merged 4 commits into from
Mar 15, 2019
Merged

fix atoms <––> uatoms conversion #2274

merged 4 commits into from
Mar 15, 2019

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Mar 14, 2019 •
edited
Loading

Closes #2273

Description:

conversion was using 10e6 instead of 1e6

Thank you! 🚀

For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

jbibla
jbibla previously approved these changes Mar 14, 2019
View reviewed changes
Copy link
Collaborator

@jbibla jbibla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok?

https://github.com/cosmos/voyager/pull/2274/files#diff-31be4419fc6502f4e4decfe73a093c46R9

@fedekunze
Copy link
Contributor Author

is this ok?

good catch

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #2274 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #2274   +/-   ##
========================================
  Coverage    96.73%   96.73%           
========================================
  Files          106      106           
  Lines         2296     2296           
  Branches       116      116           
========================================
  Hits          2221     2221           
  Misses          63       63           
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/scripts/num.js 100% <100%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #2274 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #2274   +/-   ##
========================================
  Coverage    96.73%   96.73%           
========================================
  Files          106      106           
  Lines         2296     2296           
  Branches       116      116           
========================================
  Hits          2221     2221           
  Misses          63       63           
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/scripts/num.js 100% <100%> (ø) ⬆️
.../components/governance/TabGovernanceParameters.vue
...c/renderer/components/governance/TabParameters.vue 100% <0%> (ø)

faboweb
faboweb previously approved these changes Mar 15, 2019
View reviewed changes
sabau
sabau previously approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inject the fix

@fedekunze fedekunze mentioned this pull request Mar 15, 2019
Merged
@fedekunze fedekunze dismissed stale reviews from sabau and faboweb via e758ddf March 15, 2019 10:02
sabau
sabau approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fedekunze fedekunze merged commit 0107d6f into develop Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@sabau sabau sabau approved these changes

@jbibla jbibla jbibla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

atoms are off by 10
4 participants
@fedekunze @sabau @faboweb @jbibla