Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ledger screensaver bug #2106

Merged
merged 8 commits into from
Feb 27, 2019
Merged

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Feb 26, 2019

Closes #2015

Description:

screen shot 2019-02-26 at 6 07 43 pm

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2106 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2106      +/-   ##
===========================================
+ Coverage    95.46%   95.46%   +<.01%     
===========================================
  Files          110      110              
  Lines         2578     2579       +1     
  Branches       103      103              
===========================================
+ Hits          2461     2462       +1     
  Misses         108      108              
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/ledger.js 100% <100%> (ø) ⬆️

Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@faboweb faboweb merged commit ed09a6f into develop Feb 27, 2019
@faboweb faboweb deleted the fedekunze/2015-ledger-screensaver branch February 27, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle screensaver case on ledger connection
2 participants