Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor toolbar test #2073

Merged
merged 1 commit into from
Feb 25, 2019
Merged

refactor toolbar test #2073

merged 1 commit into from
Feb 25, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Feb 24, 2019

  • new unit test stylez for Toolbar

For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb merged commit 8058d41 into develop Feb 25, 2019
@faboweb faboweb deleted the jordan/1337-toolbar-tests branch February 25, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbibla @faboweb