fedekunze/1977-fix ledger errors #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1983 +/- ##
===========================================
+ Coverage 94.86% 94.86% +<.01%
===========================================
Files 121 121
Lines 2627 2629 +2
Branches 123 123
===========================================
+ Hits 2492 2494 +2
Misses 126 126
Partials 9 9
|
added 2 commits
February 15, 2019 13:29
sabau
reviewed
Feb 15, 2019
sabau
reviewed
Feb 15, 2019
sabau
reviewed
Feb 15, 2019
sabau
reviewed
Feb 15, 2019
sabau
reviewed
Feb 15, 2019
| @@ -123,13 +129,13 @@ describe(`Module: Ledger`, () => { | |||
| }) | |||
|
|
|||
| it(`fails if one of the function throws`, async () => { | |||
| dispatch = jest.fn(async () => Promise.reject(`error`)) | |||
| dispatch = jest.fn(async () => Promise.reject(new Error(`error`))) | |||
There was a problem hiding this comment.
Probably here there are some other occurencies of jest.fn(async ... ) that can be dropped until you are not expecting something from dispatch using a simple () will work
added 2 commits
February 15, 2019 16:58
…os/voyager into fedekunze/1977-ledger-error
sabau
approved these changes
Feb 15, 2019
|
@sabau Did you manually test the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1977
Description:
Fixes error bug and makes ledger available on production
Thank you! 🚀
For contributor:
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: