Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/always upload coverage #1980

Merged
merged 5 commits into from
Feb 15, 2019
Merged

Fabo/always upload coverage #1980

merged 5 commits into from
Feb 15, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Feb 15, 2019

Intent to fix codecov check not passing when check fails

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #1980 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1980   +/-   ##
========================================
  Coverage    94.86%   94.86%           
========================================
  Files          121      121           
  Lines         2627     2627           
  Branches       123      123           
========================================
  Hits          2492     2492           
  Misses         126      126           
  Partials         9        9

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍 we always calculate the coverage

@sabau sabau merged commit e199d6a into develop Feb 15, 2019
@sabau sabau deleted the fabo/always-upload-coverage branch February 15, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants