-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabo/1911 add sentry version #1971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
test fix missing |
…ger into fabo/1911-add-sentry-version
I manually created a version running everything locally. Let's see if this works when merging into develop. |
Codecov Report
@@ Coverage Diff @@
## develop #1971 +/- ##
========================================
Coverage 95.51% 95.51%
========================================
Files 121 121
Lines 2611 2611
Branches 121 121
========================================
Hits 2494 2494
Misses 108 108
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #1971 +/- ##
========================================
Coverage 95.51% 95.51%
========================================
Files 121 121
Lines 2611 2611
Branches 121 121
========================================
Hits 2494 2494
Misses 108 108
Partials 9 9
|
In this way we are building twice the same code right? |
yeah, that was the simplest solution (webpack plugin). The upload takes quiet some time so I didn't want to run it always (not on each feature, only on develop/master). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, utACK
Closes #1911
Description:
Thank you! 🚀
For contributor:
CHANGELOG.md
with issue # and GitHub usernameFiles changed
in the github PR explorerFor reviewer: