Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1911 add sentry version #1971

Merged
merged 10 commits into from
Feb 14, 2019
Merged

Fabo/1911 add sentry version #1971

merged 10 commits into from
Feb 14, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Feb 13, 2019

Closes #1911

Description:

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

fedekunze
fedekunze previously approved these changes Feb 13, 2019
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze
Copy link
Contributor

test fix missing

@faboweb faboweb changed the title Fabo/1911 add sentry version WIP: Fabo/1911 add sentry version Feb 13, 2019
@faboweb faboweb changed the title WIP: Fabo/1911 add sentry version Fabo/1911 add sentry version Feb 13, 2019
@faboweb
Copy link
Collaborator Author

faboweb commented Feb 13, 2019

I manually created a version running everything locally. Let's see if this works when merging into develop.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #1971 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1971   +/-   ##
========================================
  Coverage    95.51%   95.51%           
========================================
  Files          121      121           
  Lines         2611     2611           
  Branches       121      121           
========================================
  Hits          2494     2494           
  Misses         108      108           
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/user.js 100% <ø> (ø) ⬆️

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #1971 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1971   +/-   ##
========================================
  Coverage    95.51%   95.51%           
========================================
  Files          121      121           
  Lines         2611     2611           
  Branches       121      121           
========================================
  Hits          2494     2494           
  Misses         108      108           
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/user.js 100% <ø> (ø) ⬆️

@sabau
Copy link
Contributor

sabau commented Feb 14, 2019

In this way we are building twice the same code right?

@faboweb
Copy link
Collaborator Author

faboweb commented Feb 14, 2019

In this way we are building twice the same code right?

yeah, that was the simplest solution (webpack plugin). The upload takes quiet some time so I didn't want to run it always (not on each feature, only on develop/master).

jbibla
jbibla previously approved these changes Feb 14, 2019
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

@fedekunze fedekunze merged commit 2e0444e into develop Feb 14, 2019
@faboweb faboweb deleted the fabo/1911-add-sentry-version branch February 14, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version not set in Sentry
4 participants