Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/1785 preferences #1874

Merged
merged 5 commits into from
Jan 23, 2019
Merged

Jordan/1785 preferences #1874

merged 5 commits into from
Jan 23, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Jan 23, 2019

Closes #1785

Description:

  • using dev flag to hide preferences
  • removed button that didn't do anything

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #1874 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1874      +/-   ##
===========================================
- Coverage    94.98%   94.97%   -0.01%     
===========================================
  Files          125      125              
  Lines         2909     2907       -2     
  Branches       117      117              
===========================================
- Hits          2763     2761       -2     
  Misses         135      135              
  Partials        11       11
Impacted Files Coverage Δ
...src/renderer/components/common/PagePreferences.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/common/TmPageHeader.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 91.66% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/delegates.js 100% <0%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #1874 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1874      +/-   ##
===========================================
- Coverage    94.98%   94.97%   -0.01%     
===========================================
  Files          125      125              
  Lines         2909     2907       -2     
  Branches       117      117              
===========================================
- Hits          2763     2761       -2     
  Misses         135      135              
  Partials        11       11
Impacted Files Coverage Δ
...src/renderer/components/common/PagePreferences.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/common/TmPageHeader.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 91.66% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/delegates.js 100% <0%> (ø) ⬆️

CHANGELOG.md Show resolved Hide resolved
@faboweb faboweb merged commit adfe7d4 into develop Jan 23, 2019
@faboweb faboweb deleted the jordan/1785-preferences branch January 23, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferences > NodeIP looks clickable
2 participants