Fabo/1835 signing methods #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbibla
reviewed
Jan 22, 2019
|
please don't include that line in the form below amount. |
which line? |
|
ahhh, ok |
Codecov Report
@@ Coverage Diff @@
## develop #1860 +/- ##
===========================================
- Coverage 95.08% 94.51% -0.58%
===========================================
Files 124 125 +1
Lines 2910 2916 +6
Branches 121 117 -4
===========================================
- Hits 2767 2756 -11
- Misses 135 150 +15
- Partials 8 10 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #1860 +/- ##
===========================================
- Coverage 95.08% 94.54% -0.54%
===========================================
Files 124 125 +1
Lines 2910 2916 +6
Branches 121 117 -4
===========================================
- Hits 2767 2757 -10
- Misses 135 150 +15
- Partials 8 9 +1
|
Codecov Report
@@ Coverage Diff @@
## develop #1860 +/- ##
===========================================
- Coverage 94.97% 94.95% -0.02%
===========================================
Files 125 125
Lines 2905 2896 -9
Branches 117 117
===========================================
- Hits 2759 2750 -9
- Misses 135 137 +2
+ Partials 11 9 -2
|
Co-Authored-By: faboweb <[email protected]>
jbibla
reviewed
Jan 25, 2019
jbibla
reviewed
Jan 25, 2019
jbibla
reviewed
Jan 25, 2019
| this.sending = true | ||
| this.$v.$touch() | ||
|
|
||
| let subFormValid = this.validate() |
There was a problem hiding this comment.
what's a subForm? and what is this.validate()?
There was a problem hiding this comment.
The actual form like SendModal. Added a bit of explanation.
jbibla
reviewed
Jan 25, 2019
jbibla
reviewed
Jan 25, 2019
jbibla
reviewed
Jan 25, 2019
jbibla
requested changes
Jan 25, 2019
There was a problem hiding this comment.
few small comments - requesting changes because @fedekunze already approved - but this is an amazing next step for ActionModals!
jbibla
reviewed
Jan 25, 2019
|
|
||
| // An ActionModal is only the prototype of a parent modal | ||
| // here we trigger the validation of the form that this parent modal | ||
| let childFormValid = this.validate() |
jbibla
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1835
Description:
Missing:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer