Avoid double voting with same option #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getVotes has been used instead of getVote as the latter throws error if the specified address did't vote yet - disable the already voted option Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]> # Conflicts: # test/unit/specs/components/governance/PageProposal.spec.js # test/unit/specs/store/governance/votes.spec.js
Codecov Report
@@ Coverage Diff @@
## develop #1728 +/- ##
==========================================
- Coverage 97.74% 97.5% -0.24%
==========================================
Files 102 102
Lines 2083 2088 +5
Branches 93 93
==========================================
Hits 2036 2036
- Misses 38 41 +3
- Partials 9 11 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #1728 +/- ##
===========================================
+ Coverage 97.74% 97.74% +<.01%
===========================================
Files 102 102
Lines 2083 2085 +2
Branches 93 93
===========================================
+ Hits 2036 2038 +2
Misses 38 38
Partials 9 9
|
- fixed lcdClientMock - added disable check for ModalVote Signed-off-by: Karoly Albert Szabo <[email protected]>
fedekunze
reviewed
Dec 10, 2018
Signed-off-by: Karoly Albert Szabo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #1683
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer